This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
implement this.fetch #203
Merged
implement this.fetch #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second half of #178. With this PR,
preloadfunctions can usethis.fetchto fetch resources. URLs are resolved against the local server, and ifcredentialsis set toincludeorsame-origin, cookies (including cookies that are about to be sent to the client) will be included.On the client,
this.fetchis just an alias forwindow.fetch.I opted for
this.fetch(rather than a) polluting the request object or b) introducing a second argument topreload) because it means that the preload context (which now includesfetch,store,errorandredirect) is something that can easily be passed around (e.g. to a set of API helpers).